smeb_y/0g-chain
1
0
Fork 0
mirror of https://github.com/0glabs/0g-chain.git synced 2024-12-25 07:45:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

resolve TODOs

Browse Source
This commit is contained in:
rhuairahrighairigh 2019-09-27 14:05:21 -04:00
parent a13e8d0379
commit 436c48c8d2
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/app.go
View File

@ -222,9 +222,11 @@ func NewApp(logger log.Logger, db dbm.DB, traceStore io.Writer, loadLatest bool,
app.mm.SetOrderEndBlockers(crisis.ModuleName, gov.ModuleName, staking.ModuleName) app.mm.SetOrderEndBlockers(crisis.ModuleName, gov.ModuleName, staking.ModuleName)
// genutils must occur after staking so that pools are properly // Note: genutils must occur after staking so that pools are properly
// initialized with tokens from genesis accounts. // initialized with tokens from genesis accounts.
// TODO should auth be first? //
// Note: Changing the order of the auth module and modules that use module accounts
// results in subtle changes to the way accounts are loaded from genesis.
app.mm.SetOrderInitGenesis( app.mm.SetOrderInitGenesis(
auth.ModuleName, distr.ModuleName, auth.ModuleName, distr.ModuleName,
staking.ModuleName, bank.ModuleName, slashing.ModuleName, staking.ModuleName, bank.ModuleName, slashing.ModuleName,

6
cli_test/cli_test.go
View File

@ -281,7 +281,7 @@ func TestGaiaCLISend(t *testing.T) {
f.Cleanup() f.Cleanup()
} }
// TODO needed? not in gaia tests // Note: this was removed from gaia due to update in sdk PR#4062 but is now working
func TestGaiaCLIConfirmTx(t *testing.T) { func TestGaiaCLIConfirmTx(t *testing.T) {
t.Parallel() t.Parallel()
f := InitFixtures(t) f := InitFixtures(t)
@ -1307,9 +1307,7 @@ func TestGaiadAddGenesisAccount(t *testing.T) {
cdc := app.MakeCodec() cdc := app.MakeCodec()
// TODO maybe replace once sdk updated authGenState := auth.GetGenesisStateFromAppState(cdc, genesisState)
var authGenState auth.GenesisState
cdc.MustUnmarshalJSON(genesisState[auth.ModuleName], &authGenState)
accounts := authGenState.Accounts accounts := authGenState.Accounts
require.Equal(t, accounts[0].GetAddress(), f.KeyAddress(keyFoo)) require.Equal(t, accounts[0].GetAddress(), f.KeyAddress(keyFoo))