From 462dad4e937438df515b16a985a5f19807e18770 Mon Sep 17 00:00:00 2001 From: Federico Kunze Date: Thu, 30 Apr 2020 13:16:30 -0400 Subject: [PATCH] address comments from review --- Makefile | 3 +++ cli_test/README.md | 14 -------------- 2 files changed, 3 insertions(+), 14 deletions(-) delete mode 100644 cli_test/README.md diff --git a/Makefile b/Makefile index 72de40af..b8c50802 100644 --- a/Makefile +++ b/Makefile @@ -135,6 +135,9 @@ test: test-rest: rest_test/./run_all_tests_from_make.sh +# Run cli integration tests +# `-p 4` to use 4 cores, `-tags cli_test` to tell go not to ignore the cli package +# These tests use the `kvd` or `kvcli` binaries in the build dir, or in `$BUILDDIR` if that env var is set. test-cli: build @go test ./cli_test -tags cli_test -v -p 4 diff --git a/cli_test/README.md b/cli_test/README.md deleted file mode 100644 index a9152712..00000000 --- a/cli_test/README.md +++ /dev/null @@ -1,14 +0,0 @@ -# CLI Integration tests - -Run the full suite: - -```bash -make build -go test -v -p 4 ./cli_test -tags cli_test -``` - -`-v` for verbose, `-p 4` to use 4 cores, `-tags cli_test` a build tag (specified in `cli_test.go`) to tell go not to ignore the package - -> NOTE: While the full suite runs in parallel, some of the tests can take up to a minute to complete - -> NOTE: The tests will use the `kvd` or `kvcli` binaries in the build dir. Or in `$BUILDDIR` if that env var is set.