Add upgrade handler
Migrates from x/evmutil to x/precisebank:
- Fractional balances
- Reserve funds
- Mints or burns coins to ensure fractional balances are fully backed.
Initialize remainder if necessary to ensure valid state.
E2E test with fixed kvtool
* feat!(precompile): Add registry and genesis tests
Based on evgeniy-scherbina's work, this adds a new precompile module
which defines a contract moudule with an example noop contract that
will be will be used for implementing test functions. In addition,
it defines a registry module that instantiates stateful precompile
contracts and associates them with an address in a global registry
defined in kava-labs/go-ethereum. See precompile/README.md for more
information.
The kava-labs/go-ethereum and kava-labs/etheremint replace statements
are updated to support these changes as well as an update to kvtool
which includes genesis state for the registry.NoopContractAddress and
initializes the contract's EthAccount with a non-zero sequence and
codehash set to keccak256(0x01), and sets the contract code to 0x01.
See tests/e2e/e2e_precompile_genesis_test.go for an overview of the
expected genesis state for an enabled precompile.
Co-authored-by: evgeniy-scherbina <evgeniy.shcherbina.es@gmail.com>
* chore: Precompile readme improvements
This fixes a typo (import -> important) and uses package terminology
instead of unclear module terminology. This aligns best with golang
terminology were modules and packages are distinctly different and
modules are defined using go.mod.
* chore: Improve noop contract godoc
Add a more meaningful godoc where the noop contract is constructed.
* chore(e2e): Improve comments around query checks
Improve the clarity of comments around where the error is checked for
accounts and why it is not checked directly.
In addition, improve comment on why both grpc and rpc code is fetched
and where they are used.
---------
Co-authored-by: evgeniy-scherbina <evgeniy.shcherbina.es@gmail.com>
Implement GetBalance for extended balances which passes through to `x/bank` for non-extended denoms. This diverges from `x/evmutil` behavior which will panic on non-"akava" calls.
Add bank / account keeper mocks for testing, with mockery config for [mockery package setup](https://vektra.github.io/mockery/latest/migrating_to_packages/)
* Update cometbft, cosmos, ethermint, and ibc-go
* Replace github.com/tendermint/tendermint by github.com/cometbft/cometbft
* Replace github.com/tendermint/tm-db by github.com/cometbft/cometbft-db
* Replace gogo/protobuf with cosmos/gogoproto & simapp replacement
* Replace cosmos-sdk/simapp/helpers with cosmos-sdk/testutil/sims
* Remove no longer used simulations
* Replace ibchost with ibcexported
See https://github.com/cosmos/ibc-go/blob/v7.2.2/docs/migrations/v6-to-v7.md#ibc-module-constants
* Add new consensus params keeper
* Add consensus keeper to blockers
* Fix keeper and module issues in app.go
* Add IsSendEnabledCoins and update SetParams interface changes
* Fix protobuf build for cosmos 47 (#1800)
* fix cp errors by using -f; fix lint by only linting our proto dir;
and use proofs.proto directly from ics23 for ibc-go v7
* run proto-all; commit updated third party deps and swagger changes
* regenerate proto files
* use correct gocosmos build plugin for buf
* re-gen all protobuf files to update paths for new gocosmos plugin
* update protoc and buf to latest versions
* fix staking keeper issues in app.go
* update tally handler for gov changes
* chain id fix and flag fixes
* update deps for cometbft 47.7 upgrade
* remove all module legacy queriers
* update stakingKeeper to pointer
* Replace ModuleCdc from govv1beta1 to govcodec
* remove simulations
* abci.LastCommitInfo → abci.CommitInfo
* Remove unused code in keys.go
* simapp.MakeTestEncodingConfig -> moduletestutil.MakeTestEncodingConfi
* Fix chain id issues in tests
* Fix remaining unit test issues
* Update changelog for upgrade
* Fix e2e tests using updated kvtool
* Update protonet to v47 compatible genesis
* Bump cometbft-db to v0.9.1-kava.1
* Update kvtool
* Remove extra changelog
* Fix merged rocksdb issues
* go mod cleanup
* Bump cometbft-db to v9 and go to 1.21
* Bump rocksdb version to v8.10.0
* Update kvtool to latest version
* Update gin to v1.9.0
* Use ibctm.ModuleName in app_test
* Fallback to genesis chain id instead of client toml
* Remove all simulations
* Fix cdp migrations issue with v47
* Update dependencies to correct tags
---------
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
* Add authority, MsgUpdateParams
* Add e2e test for x/community UpdateParamsMsg proposal
* Ensure new params are different
* Add errors and update codec
* Update changelog
* Use single reused govAuthorityAddr
* Add unit tests for authority and msg
* Validate authority address
* Update proto comment
* Check for ErrInvalidSigner in invalid authority error
* Emit events for staking rewards
* Update test to check disable inflation check
* Only emit staking rewards event when non-zero value
* use existing transfer amount for event
* add assertion that no events are emitted for zero rewards; refactor
event assertions to be a little cleaner
---------
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
* add new field upgrade_time_set_staking_rewards_per_second with intention
of integrating into the disable inflation logic to set an initial
staking reward time
* when the disable inflation upgrade time occurs, set the staking rewards
per second to the value specified by the new
upgrade_time_set_staking_rewards_per_second. This will allow a decoupled
implementation between the ugprade switching logic, and the core
functionality of paying staking rewards from the pool
* add staking rewards state to community keeper and community module
genesis that is required to calculate and track staking reward payouts
accross blocks
* add implementation of staking reward payouts
* remove unused error
* touch up tests and add a test case that fully tests behavior when pool
is drained
* add function comments
* refactor and pull out main calculation to private pure function with
no dependence on keeper
* zero out default parameters -- these are too chain specific to have
useful defaults
* small touch ups on comments, test cases
* use correct Int from sdkmath, not old sdk types; update protonet genesis
for new parmater
* fix copy pasta comment
* use bond denom from staking keeper instead of referncing ukava directly
* add staking reward state for valid genesis
* update kvtool genesis for new params and rewards state
* feat: disable inflation upgrade logic
* improve disable inflation comments
* add upgrade tests
* update changelog
* split disable inflation upgrade and the upgrade check
* remove pay rewards logic
* clean up incentives test
* add abci test
* refactor upgradeTime and blockTime check
* fix abci test
* fix wrong pr in changelog
* refactor disable inflation tests, behavior, and implementation
- Unit tests are now shared between keeper and abci begin blocker
since behavior is 100% the same
- ABCI is unaware of keeper initial keeper logic branch (keeper
methods required to be called in certain order by begin blocker)
- Behavior of zero time is changed -- this now doesn't run for the
zero time. This is more ideal for new chains (genesis should set
all correct state instead of relying on inflation disable logic),
and allows for a simpler implementation.
- Begin blocker now panics if parameters are not in state
* remove previous tests and implementation
* remove previous block time keeper state -- not needed for inflation
disalbing
* move inflation disabling to private method and add more comments
* remove unused key
* use correct spelling for idempotence
---------
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
* add community params type
* add get/set params methods
* add community genesis state type
* add community init/export genesis
* add querier methods for params
* add query cli cmd
* update changelog
* update protonet genesis
* Add `RewardsPerSecond` param to `x/community` module (#1707)
* Add RewardsPerSecond param to community
* Update rewards per second param to int
* Add rewards_per_second to protonet genesis
* Use default rewards per second of 744191
* Include value if negative in Validate error
* Rename RewardsPerSecond param to StakingRewardsPerSecond
* Add changelog entry
* Add param migration, update consensus version to 2
* Update proto docs
* Update staking_rewards_per_second param name in protonet genesis (#1730)
* Update godoc
Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
* add genesis state tests
* document what 0 upgrade time means
* update kvtool to include new params
---------
Co-authored-by: drklee3 <derrick@dlee.dev>
Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
* initialize x/metrics with metrics collection
* include global labels in x/metrics metrics
* add x/metrics spec
* add x/metrics test coverage
* update changelog
* fix(evmutil): create module account on InitGenesis
ensures the creation of the x/evmutil module account on init genesis.
* update changelog
* cleanup debug logging
* add amino registration test
* register evmutil types on app amino codec
* register new msg type in amino and proto,
also use new register method that checks length to catch ledger issues
* clarify variable naming
* add proto for allowed sdk denoms -> evm conversion
* add validation for AllowedNativeCoinERC20Token
* add validation for AllowedNativeCoinERC20Tokens
* add AllowedNativeDenoms into params & genesis
* add evmutil Params.Validate() test
* fix eip712 ante test
* update changelog
* update internal testnet genesis.json
* update state & param specs
updates to the sections describing functionality will be updated once
that functionality actually exists... :)
* update field decimal -> decimals
field now matches erc20 spec
* add validation decimals will cast to uint8
* add v2 store migration for evmutil
* create & register evmutil migrations
* adds migrator to evmutil's keeper
* sets up Migrate1To2 migration
* registers migration in module
* updates GetParams to properly handle historic block queries
* add unit test for GetParams with historic store
* add CommunityPoolCDPRepayDebtProposal proto & type
* add cdpKeeper to x/community's keeper
* add handler for CommunityPoolCDPRepayDebtProposal
* more test cases
* rename CommunityPoolCDP -> CommunityCDP
the proposal does not interact with the vanilla community pool
* fix & test stringer
* update changelog
* Use cosmossdk.io/errors for deprecated error methods
* Update error registration with cosmossdk.io/errors
* Use cosmossdk.io/math for deprecated sdk.Int alias
* Fix modified proto file
* Update sdk.Int usage in swap hooks
* Update e2e test deprecated method usage
* Update cosmos-sdk to v0.45.10-kava
* Add RegisterNodeService to app
* Update cosmos proto files
* Update cosmos proto files
* Use tagged v0.45.10-kava-v0.19-0.21 cosmos version
* update x/auth/legacy to x/auth/migrations
* Delete rest packages and registration
* Remove rest from proposal handlers
* Remove legacy types referencing removed sdk types
* Remove legacy tx broadcast handler
* Update incentive staking hooks to return error
* Remove grpc replace directive, use new grpc version
* Fix storetypes import
* Update tally_handler with updated gov types
* Delete legacy types
* Use new gov default config
* Update RegisterTendermintService params
Signed-off-by: drklee3 <derrick@dlee.dev>
* Replace sdk.StoreKey with storetypes.StoreKey
* Replace sdk.Int#ToDec with sdk.NewDecFromInt
* Replace sdk.NewUintFromBigInt with sdkmath.NewUintFromBigInt
Signed-off-by: drklee3 <derrick@dlee.dev>
* Update most intances of govtypes to govv1beta1
* Unpack coin slice for Coins#Sub and Coins#SafeSub
Signed-off-by: drklee3 <derrick@dlee.dev>
* Update committee gov codec registration
Signed-off-by: drklee3 <derrick@dlee.dev>
* Update migrate utils period_vesting Coins#Sub
Signed-off-by: drklee3 <derrick@dlee.dev>
* Update Coin#Sub in community proposal handler
Signed-off-by: drklee3 <derrick@dlee.dev>
* Update Coin#Sub, FundModuleAccount/FundAccount in banktestutil
Signed-off-by: drklee3 <derrick@dlee.dev>
* Update community, earn, kavadist proposal gov registration
* Update evm cli client EthSecp256k1Type check
* AccAddressFromHex to AccAddressFromHexUnsafe
* Add mint DefaultInflationCalculationFn to earn test
* Update use of removed staking.NewHandler
* Rename FlagIAVLFastNode -> FlagDisableIAVLFastNode
* cmd: Update new snapshot app option
Signed-off-by: drklee3 <derrick@dlee.dev>
* cmd: Add tendermint default config, use cosmos rpc status command
Signed-off-by: drklee3 <derrick@dlee.dev>
* Update ethermint import path
github.com/tharsis/ethermint -> github.com/evmos/ethermint
* Upgrade ibc-go to v6
* Update proto dependencies
Signed-off-by: drklee3 <derrick@dlee.dev>
* Update Tally handler test with new gov types
* Update helpers.GenTx -> helpers.GenSignedMockTx
* Update evmkeeper.NewKeeper params
Signed-off-by: drklee3 <derrick@dlee.dev>
* Update ante authz, tests
* Add feemarket transient key, pass subspaces to evm/feemarket keepers
* Update new ante decorators
* Add new addModuleInitFlags to server commands
* Pass codec to keyring.New in genaccounts
* Pass codec to client keys add
* Add SendCoins to evmutil bank_keeper
* Use github.com/cosmos/iavl@v0.19.5
* Add ante HandlerOptions
* Add unimplemented SendCoins to evmutil bank keeper
Ethermint x/evm does not use this method
* Update init-new-chain script to disable post-london blocks
* Modify test genesis states to append 1 validator
* Update tally handler test to use string values
* Prevent querying balance for empty sdk.AccAddress in auction bidding test
* Set default bond denom to ukava
* Remove overwritten bank genesis total supply in committee proposal test
Signed-off-by: drklee3 <derrick@dlee.dev>
* Use ukava for testing staked balance
* Disable minting in community proposal handler test
Previously stake denom is used, which resulted in 0 minted coins
* Update hard APYToSPY test expected value
Increased iterations in sdk.ApproxRoot, updated closer to real value
* Fix NewDecCoinsFromCoins bug in incentive collectDerivativeStakingRewards
* Allow bkava earn incentive test values to match within small margin for rounding
Signed-off-by: drklee3 <derrick@dlee.dev>
* Update invalid denom in issuance message coin validation
Colons are now valid in denoms
Signed-off-by: drklee3 <derrick@dlee.dev>
* Remove genesis validator in incentive delegation tests
* Update pricefeed market test for invalid denom
Signed-off-by: drklee3 <derrick@dlee.dev>
* Update incentive delegator rewards test without genesis validator
Signed-off-by: drklee3 <derrick@dlee.dev>
* Add validator to export test
* Clear bank state in minting tests
Signed-off-by: drklee3 <derrick@dlee.dev>
* Remove validator for no stake tally test
Signed-off-by: drklee3 <derrick@dlee.dev>
* Clear incentive state before InitGenesis in incentive genesis export test
* Update swagger
Signed-off-by: drklee3 <derrick@dlee.dev>
* Update ethermint version to match replaced version
* Remove legacy swagger
* Add NewEthEmitEventDecorator
* Remove redundant func for AddModuleInitFlags
* Remove unused addBankBalanceForAddress func
* Add SetIAVLLazyLoading option to app cmd
* Use legacy.RegisterAminoMsg for committee msg concrete registration
* Remove unnecessary Amino field
* Add evm_util bankkeeper SendCoins comment
* Update test method ResetBankState to DeleteGenesisValidatorCoins to be more clear
* Validate incentive params.RewardsPerSecond to be non-zero
* Validate swap pools to disallow colons in token denoms
* Register all legacy amino types on gov modulecdc
* Remove redundant Comittee interface registration
* Pin goleveldb to v1.0.1-0.20210819022825-2ae1ddf74ef7
Causes failed to load state at height errors
* Update ethermint to new pinned version with minGasPrices parse error fix
* Update cosmos fork dependcy commit to include reverted account constructor patch
* Update Cosmos v0.46.11 and cometbft v0.34.27
* Bump minimum go version to 1.19
* Update tendermint proto
* Update internal testnet genesis
* Move NewCanTransferDecorator before NewEthGasConsumeDecorator
* Add hard borrow store tests (#1514)
* add store tests for Borrow type
* refactor Deposit tests to match
* Fix old bep3 tests (#1515)
* Update Ethermint to 1b17445 to fix duplicate proto registration
* Add custom status command to use snake_case and stdout
* Add SetInflation helper
* Reduce ambiguity with evm CanSignEthTx error
* Remove init genesis validator claim in test
* Add disabled evmante.NewMinGasPriceDecorator with x/feemarket note
* chore: use tagged versions for Cosmos and Ethermint forks
* update kvtool & increase wait for ibc transfer test
---------
Signed-off-by: drklee3 <derrick@dlee.dev>
Co-authored-by: Ruaridh <rhuairahrighairidh@users.noreply.github.com>
Co-authored-by: Robert Pirtle <astropirtle@gmail.com>
* add proto for LegacyCommunityPool query
* add distribution keeper to community keeper
* implement LegacyCommunityPool query
* add cli cmd for legacy-community-pool
* initial version
* override x/distribution community-pool query
* test subset of original x/distribution queries
Co-authored-by: rhuairahrighairigh <ruaridh.odonnell@gmail.com>
* use kavamint in incentive to calculate staking apy
* use kavamint minting: rewards_earn_staking_integration_test
* update incentive tests to mint only with kavamint
* remove x/mint from incentive tests
* remove x/mint from kava app
* fix minting in x/auction tests
* replace simapp fund calls with test helper
* remove mint state from genesis.json
* add `x/kavamint` module (#1376)
* stub out the x/kavamint module
* mint staking rewards in x/kavamint BeginBlocker
* calculate cumulative inflation from x/kavamint
* cleanup, abstract bond denom, grpc query tests
* store & use previous block time to calculate mints
* move test suite to testutil
* add test of x/kavamint BeginBlocker
* cleanup & comments from @DracoLi review
* fix x/incentive integration test
* remove rest client grpc test
* add x/kavamint module spec
* track previous block time in genesis
* suggested cleanup from PR review
* bugfix incorrect module account check
* add x/community module (#1388)
* add x/community module
* refactor and setup fund-community-pool tx
* remove unused features (params, genesis state)
* test x/community query and message
* update with master branch deps
* updates from review
* indicate deprecated methods on module (still needed to fulfill interface)
* remove legacy querier
* derive msg Route() and Type() from sdk.MsgTypeURL(&msg)
* use module name for message Route()
* mint community pool inflation in x/kavamint (#1389)
* mint community pool inflation in x/kavamint
* refactor x/kavamint abci inflation test
* test inflation from x/kavamint
* default kavamint rates to 0%
* rename kavamint account name variables
* panic if genesis kavamint previous block time not set
* emit event on kavamint begin blocker
* add kavamint year of inflation sanity check test
* update fund_community_pool message event
* add x/community spec
* refactor inflation accumulation into single func
* use new comm pool in kavadist multispend proposal (#1403)
the x/community module houses the new community pool. this commit
points the CommunityPoolMultiSpendProposal at the new community pool
so that multispend proposals can continue to be processed once original
fee pool funds are move to x/community
* updates from proto lint changes
* update earn proposals to use new community pool
originally the CommunityPoolDepositProposal & CommunityPoolWithdrawProposal
used the vanilla community pool fee pool. this commit updates them both
to use the new x/community module account.
* spec formatting update
* add x/community & x/kavamint to internal testnet genesis
* increase test coverage of x/kavamint
* increase test coverage of x/community
* use string type for sdk.Dec proto fields; disable generation of getters
for genesis and params (and other store objects)
* follow sdk conventions for params endpoint naming
* add kavamint to swagger; update swagger & proto docs
* remove legacy querier; touch up module to match others
* reduce max minting rate; refactor genesis to allow nil/zero block time;
repace proto stringers and remove getters; keep sdk.Dec values strings
in protos; increase validation of sdk.Dec values in params; increase
coverage; add module account permission checks; ensure import and export
of genesis does not change state
* fix scaling of rate values -- should be yearly rates
* revert key change
* fix typo in test name
* fix regression in running tests -- rename method
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
* Add initial earn claim migrations
* Use existing types for migrations, add accural time migrations
* Add MigrateRewardIndexes
* Delete old state after migration
* Update store test with multiple entries
* Move key methods to keys.go
* Update incentive consensus version to 3
* Call MigrateRewardIndexes in main migration, remove debugging statements
* Fix migration version to v3
* Update module versions
* Update outdated v1 comment
