Commit Graph

68 Commits

Author SHA1 Message Date
rhuairahrighairigh
976f8f632d remove todo - leave to caller to deal with panic 2020-05-08 16:10:59 +01:00
rhuairahrighairigh
4039086e8d tidy up events 2020-05-08 16:07:11 +01:00
Jack Zampolin
f86d0f3c3b Add changes from code review 2020-05-04 10:52:36 -07:00
Federico Kunze
511e1e07ac
fix conflicts from development 2020-04-30 17:12:22 -04:00
Kevin Davis
22bba81944
Check spendable balance in cdp sims (#480)
* fix: check spendable balance

* don't log noisy result.Log

* remove dead comment
2020-04-30 17:02:42 -04:00
Federico Kunze
fe72a24aa0
update format 2020-04-30 10:23:41 -04:00
Federico Kunze
8853e8d3d1
linters and format 2020-04-30 10:13:31 -04:00
Kevin Davis
23e23fdaaa
fix: restore auction sims operations (#465) 2020-04-23 14:51:37 -07:00
Denali Marsh
a4c5a13822
[R4R] BEP3 module spec and clean up (#450)
* bump SDK version to v0.38.2

* fix module.go and remove codespaces

* fix coins Add()

* fixes to handlers

* migrate errors

* more fixes

* fixes fixes fixes

* build

* check for paramstore keytable

* empty param validation function (TODO)

* param validations

* fix some tests

* fix all tests

* simulation fixes (WIP)

* auction and bep3 sim refactor

* fixes

* bep3 sims fixes

* auction and pricefeed fix

* cdp sims fixes

* fix tests

* Update x/auction/keeper/auctions.go

Co-Authored-By: Denali Marsh <denali@kava.io>

* Update x/bep3/types/params.go

Co-Authored-By: Denali Marsh <denali@kava.io>

* Apply suggestions from code review

Co-Authored-By: Denali Marsh <denali@kava.io>

* Update x/bep3/keeper/swap.go

Co-Authored-By: Denali Marsh <denali@kava.io>

* address comments from review

* address comments from review

* fix: run sims

* fix: implement marshal/unmarshal JSON for validator vesting account

* fix: don't call set on sealed config

* remove swap interface

* add concepts spec

* add state spec

* add messages spec

* update event names

* implement swap expired event

* add events spec

* add params spec

* add begin block spec

* add module readme

* update alias

* revisions

* aggregate expired swap ids for event emisison

* markdown-link-check-disable for circleci

* exclude api-endpoint links in Makefile

Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Kevin Davis <kjydavis3@gmail.com>
2020-04-23 13:57:25 -07:00
Federico Kunze
a573625df8
[R4R] bump SDK version to v0.38.3 (#421)
* bump SDK version to v0.38.3

Co-authored-by: Denali Marsh <denali@kava.io>
Co-authored-by: Kevin Davis <kjydavis3@gmail.com>
Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
Co-authored-by: denalimarsh <denalimarsh@gmail.com>
Co-authored-by: rhuairahrighairigh <ruaridh.odonnell@gmail.com>
2020-04-23 12:35:58 -04:00
Kevin Davis
acc96952a7
fix: non-determinism in auction sims (#432) 2020-04-14 13:49:31 -04:00
Ruaridh
5bdffd5c1c
Add Auction Simulations (#419)
* first pass

* fix bid amount calculation

* untested refactor of sim ops and genesis

* refactor operations and fix auction bug

* add param changes and genesis

* address minor TODO

* add first draft of invariants

* improve param generation

* complete invariants

* fix genesis tests

* log no-op better

* small fixes

* add missed comma

Co-authored-by: John Maheswaran <john@kava.io>
2020-04-13 17:01:54 +01:00
Federico Kunze
3f4aba1c7f
decoder tests 2020-04-04 19:42:35 -03:00
Federico Kunze
e02766bff3
x/auction: simulation decoder 2020-04-01 13:33:18 -03:00
Ruaridh
7eede47769
Add min bid increments (#380)
* refactor bidding test

* add some more bid test cases

* add balance checks to bid tests

* add more checks to bid tests

* add min bid increments

* protect against negative lot amounts

* fix params tests

* change endblocker to beginblocker

* update spec

* fix params tests

* fix: update alias

Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
2020-02-28 17:16:22 -05:00
Kevin Davis
0c6459346d fix: use standard abci query convention 2020-02-27 12:59:11 -05:00
Ruaridh
c7b1331f4d
Fix simulations (#377)
* stub out simulation integration for cdp, pricefeed

* stub out simulation integration for auction

* fix cdp export

* update pricefeed to match

* update validator-vesting to match
2020-02-25 10:11:09 -05:00
Ruaridh
ed57dd6ff1
Auction rest endpoints bugfix (#363)
* remove parameter brackets

* remove more param brackets
2020-02-04 12:56:10 -05:00
Ruaridh
bbc5d3b7a0
Auction rest fixes (#361)
* auction query fixes

* minor formating tweaks

* add phase info to debt & surplus auctions

* add base auction struct tags

* use module name in querier paths

* update rest tx endoint to use http body

* improve invalid coins error messages

* add rest examples

* align starting auction ID with gov and cdp

* fix cdp test broken by auction ID change

* fix all tests broken by ID change
2020-02-03 10:54:00 -05:00
Ruaridh
183acfef62
auction query fixes (#354) 2020-02-01 10:49:36 -05:00
Kevin Davis
55f0f8d980
Display auction type and phase when querying auctions (#345)
* feat: differentiate auction types when queried

* feat: display auction type

* feat: add phase of collateral auctions

* fix: set reverse phase directly

* feat: revert base auction, use querying specifc structs

* fix: pass auction as interface to handlers

* set reverse phase on max bid (#348)

* Revert "set reverse phase on max bid (#348)" (#351)

This reverts commit 4b855250d529a4cbecb16d9d32b25ffeaffa3a68.

* fix: missing return

* fix: include collateral auction type

* fix: always include phase field for queries

Co-authored-by: Denali Marsh <denalimarsh@gmail.com>
2020-01-29 08:42:03 -06:00
Ruaridh
d24f364ed3
add weighted address tags (#336) 2020-01-24 11:39:52 +00:00
Ruaridh
e11b298c28 Add CDP Spec (#328)
* add overview and basic structure

* add state and params

* add basic messages

* add state transitions

* add begin block state transitions

* add missing titles

* add concepts

* add events

* update state and concepts

* update for liquidator changes

* update events

* mention module accounts

* update begin block

* update params

* update page numbering

* add fee descriptions

* add broken link linter

* add broken link linter to CI

* move link check to end of CI

* update typo

Co-Authored-By: Kevin Davis <karzak@users.noreply.github.com>

* address review comments

* Update x/cdp/spec/06_params.md

Co-Authored-By: Kevin Davis <karzak@users.noreply.github.com>

* Update x/cdp/spec/README.md

Co-Authored-By: Kevin Davis <karzak@users.noreply.github.com>

* Update x/cdp/spec/README.md

Co-Authored-By: Kevin Davis <karzak@users.noreply.github.com>

Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
2020-01-23 14:09:36 -05:00
Ruaridh
f01a3f46ee
Auction cli/rest fixes (#319)
* cleanup auction tx cli

* add querier for getting one auction

* missed querier fixes

* update querier tests

* add msg struct tags

* add auction rest endpoint and tidy

* add struct tags to auctions

* minor UX tweaks
2020-01-21 17:41:37 +00:00
Ruaridh
2be1a3196e
make bidding tests independent (#322) 2020-01-21 10:06:07 +00:00
Denali Marsh
d286f53053
R4R: cli auction clean up (#310)
* kvcli q auction params

* reset go.sum

* Updated QueryGetAuctionsCmd naming to match conventions

* clean up: tx auctions placebid

* requested changes
2020-01-16 18:52:29 +01:00
Kevin Davis
2193b19c1d fix: genesis auctions tag 2020-01-16 16:17:16 +01:00
Kevin Davis
407361313e chore: linting 2020-01-16 12:15:27 +01:00
Kevin Davis
6bf1a4ce5b fix: genesis param json tags 2020-01-16 12:15:18 +01:00
Kevin Davis
9b1bf55be7
R4R: Move liquidator functions to cdp module (#280)
* wip: tpyes and keeper methods

* wip: iterators

* wip: types and keeper methods

* wip: add msgs

* wip: client methods

* wip: rebase develop

* wip: types tests

* wip: keeper tests, small fixes

* wip: add cdp tests

* wip: deposit tests

* wip: keeper tests

* wip: tests and module methods

* feat: error when fetching expired price

* feat: conversion factor for external assets

* feat: debt floor for new cdps

* feat: save deposits on export genesis

* feat: ensure messages implement msg

* feat: index deposits by status

* fix: stray comment

* wip: address review comments

* address review comments

* wip: move liquidation to cdp module

* wip: handle liquidations directly

* wip: use new auction interface

* feat: auction collateral in cdp begin block

* feat: update param validation

* feat: surplus and debt auctions

* address review comments

* address review comments

* fix: auction multiple deposits

* clean up netting function
2020-01-15 15:19:33 +01:00
Denali Marsh
ba80b508ab [R4R] Custom sdk.Error types for the auction module (#285)
* Custom sdk.Error types for the auction module

* Requested changes: naming conventions, error message text
2020-01-15 11:39:55 +01:00
Kevin Davis
8128a680cc
Ro address auction todos (#284)
* make auctions not expire without bids

* add events

* improve genesis state validation

* add genesis tests

* Keeper auctions test, types auctions test, keeper bidding test

* Resolved TODOs, added querier test

* Removed 'import x/liquidator' from keeper_test package for circleci

* Fixes for lack of liquidator module account in tests

* update comment

Co-Authored-By: Kevin Davis <karzak@users.noreply.github.com>

* add more events attributes

* feat: add back bidding on closed auction test

* feat: test failed debt/collateral auctions

Co-authored-by: Ruaridh <rhuairahrighairidh@users.noreply.github.com>
Co-authored-by: Denali Marsh <denalimarsh@gmail.com>
2020-01-14 16:04:47 +01:00
Ruaridh
22e168d06a Various Auction TODOs (#281)
* make auctions not expire without bids

* add events

* improve genesis state validation

* add genesis tests

* update comment

Co-Authored-By: Kevin Davis <karzak@users.noreply.github.com>

* add more events attributes

Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
2020-01-14 15:00:37 +01:00
rhuairahrighairigh
aa6dfab6fd Merge branch 'ro-add-debt-tracking-to-auctions' 2020-01-14 12:10:39 +01:00
Kevin Davis
d849d690e5
R4R: CDP types and methods (#275)
* wip: tpyes and keeper methods

* wip: iterators

* wip: types and keeper methods

* wip: add msgs

* wip: client methods

* wip: rebase develop

* wip: types tests

* wip: keeper tests, small fixes

* wip: add cdp tests

* wip: deposit tests

* wip: keeper tests

* wip: tests and module methods

* feat: error when fetching expired price

* feat: conversion factor for external assets

* feat: debt floor for new cdps

* feat: save deposits on export genesis

* feat: ensure messages implement msg

* feat: index deposits by status

* fix: stray comment

* wip: address review comments

* address review comments
2020-01-12 16:35:34 +01:00
Ruaridh
e1c11d411a Update Auction Module (#276)
* rough auction type refactor

* replace endTime type

* split keeper file up

* update store methods

* move store methods to keeper.go

* move nextAuctionID from params to genState

* simplify auction type to not use pointers

* add basic auction tests

* update endblocker test

* add payout to depositors feature

* add more tests

* move index updates to Get/Set for more safety

* remove slightly unecessary ID type

* remove unused message types

* feat: add spec, update redundant type names

* stop sending zero coins

* use only one coins field in MsgPlaceBid

* remove uncessary Auction interface methods

* give auction types more accurate names

* remove vuepress comments from spec

* minor spec updates

* update doc comments

* add params validation

* code cleanup, address review comments

* resolve minor TODOs

* sync spec with code

Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
2020-01-12 16:12:22 +01:00
rhuairahrighairigh
61e5de556c add debt tracking to auctions 2020-01-12 15:17:47 +01:00
rhuairahrighairigh
27f3e76da3 sync spec with code 2020-01-10 18:57:38 +01:00
rhuairahrighairigh
65ef8a9ba3 resolve minor TODOs 2020-01-10 18:55:48 +01:00
rhuairahrighairigh
d03509a17a code cleanup, address review comments 2020-01-10 14:08:47 +00:00
rhuairahrighairigh
00c1a371d2 add params validation 2020-01-10 13:13:04 +00:00
rhuairahrighairigh
2537928ee7 update doc comments 2020-01-09 17:25:16 +00:00
rhuairahrighairigh
fecfee5077 minor spec updates 2020-01-09 16:21:42 +00:00
rhuairahrighairigh
08d6bc2284 remove vuepress comments from spec 2020-01-09 16:14:55 +00:00
rhuairahrighairigh
c239932297 give auction types more accurate names 2020-01-09 16:09:19 +00:00
rhuairahrighairigh
08689305cc remove uncessary Auction interface methods 2020-01-09 15:43:42 +00:00
rhuairahrighairigh
48a2d5b6dc use only one coins field in MsgPlaceBid 2020-01-09 14:58:47 +00:00
rhuairahrighairigh
3a7cb7e4f6 stop sending zero coins 2020-01-09 13:55:45 +00:00
Kevin Davis
de4f55ea20 feat: add spec, update redundant type names 2020-01-07 12:17:27 -05:00
rhuairahrighairigh
b2fa8d81ee remove unused message types 2020-01-06 16:35:50 +00:00