smeb_y/0g-storage-node
1
0
Fork 0
mirror of https://github.com/0glabs/0g-storage-node.git synced 2025-11-03 08:07:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

unnecessary loop

Browse Source
This commit is contained in:
Peter Zhang 2025-07-08 08:19:40 +08:00
parent ce9977ff29
commit 00a0d9499d
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
node/storage/src/log_store/log_manager.rs
View File

@ -273,7 +273,7 @@ impl LogStoreWrite for LogManager {
bail!("unexpected tx!"); bail!("unexpected tx!");
} }
} }
let same_data_tx_seqs = self.tx_store.put_tx(tx.clone())?; let maybe_same_data_tx_seq = self.tx_store.put_tx(tx.clone())?.first().cloned();
// TODO(zz): Should we validate received tx? // TODO(zz): Should we validate received tx?
self.append_subtree_list( self.append_subtree_list(
tx.seq, tx.seq,
@ -289,11 +289,10 @@ impl LogStoreWrite for LogManager {
// Drop the lock because `copy_tx_data` will lock again. // Drop the lock because `copy_tx_data` will lock again.
drop(merkle); drop(merkle);
for old_tx_seq in same_data_tx_seqs { if let Some(old_tx_seq) = maybe_same_data_tx_seq {
if self.check_tx_completed(old_tx_seq)? { if self.check_tx_completed(old_tx_seq)? {
// copy and finalize once, then stop // copy and finalize once, then stop
self.copy_tx_and_finalize(old_tx_seq, vec![tx.seq])?; self.copy_tx_and_finalize(old_tx_seq, vec![tx.seq])?;
break;
} }
} }
metrics::PUT_TX.update_since(start_time); metrics::PUT_TX.update_since(start_time);
@ -317,7 +316,7 @@ impl LogStoreWrite for LogManager {
.get_tx_seq_list_by_data_root(&tx.data_merkle_root)?; .get_tx_seq_list_by_data_root(&tx.data_merkle_root)?;
// Check if there are other same-root transaction not finalized. // Check if there are other same-root transaction not finalized.
self.copy_tx_and_finalize(tx_seq, same_root_seq_list)?; self.copy_tx_and_finalize(tx_seq, same_root_seq_list)?;
self.tx_store.finalize_tx(tx_seq)?; self.tx_store.finalize_tx(tx_seq)?;
Ok(()) Ok(())
} else { } else {
@ -353,7 +352,7 @@ impl LogStoreWrite for LogManager {
.get_tx_seq_list_by_data_root(&tx.data_merkle_root)?; .get_tx_seq_list_by_data_root(&tx.data_merkle_root)?;
// Check if there are other same-root transaction not finalized. // Check if there are other same-root transaction not finalized.
self.copy_tx_and_finalize(tx_seq, same_root_seq_list)?; self.copy_tx_and_finalize(tx_seq, same_root_seq_list)?;
metrics::FINALIZE_TX_WITH_HASH.update_since(start_time); metrics::FINALIZE_TX_WITH_HASH.update_since(start_time);
Ok(true) Ok(true)
} else { } else {