smeb_y/0g-storage-node
1
0
Fork 0
mirror of https://github.com/0glabs/0g-storage-node.git synced 2025-11-03 16:17:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

prevent attack on uploading multiple files to increase db read load

Browse Source
This commit is contained in:
Peter Zhang 2025-07-08 11:13:52 +08:00
parent 4126ac97f7
commit 1381428aee
1 changed files with 24 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
node/storage/src/log_store/log_manager.rs
View File

@ -315,7 +315,18 @@ impl LogStoreWrite for LogManager {
.tx_store .tx_store
.get_tx_seq_list_by_data_root(&tx.data_merkle_root)?; .get_tx_seq_list_by_data_root(&tx.data_merkle_root)?;
// Check if there are other same-root transaction not finalized. // Check if there are other same-root transaction not finalized.
self.copy_tx_and_finalize(tx_seq, same_root_seq_list)?; if same_root_seq_list.first() == Some(&tx_seq) {
// If this is the first tx with this data root, copy and finalize all same-root txs.
self.copy_tx_and_finalize(tx_seq, same_root_seq_list[1..].to_vec())?;
} else {
// If this is not the first tx with this data root, copy and finalize the first one.
let maybe_first_seq = same_root_seq_list.first().cloned();
if let Some(first_seq) = maybe_first_seq {
if !self.check_tx_completed(first_seq)? {
self.copy_tx_and_finalize(tx_seq, vec![first_seq])?;
}
}
}
self.tx_store.finalize_tx(tx_seq)?; self.tx_store.finalize_tx(tx_seq)?;
Ok(()) Ok(())
@ -351,11 +362,18 @@ impl LogStoreWrite for LogManager {
.tx_store .tx_store
.get_tx_seq_list_by_data_root(&tx.data_merkle_root)?; .get_tx_seq_list_by_data_root(&tx.data_merkle_root)?;
// Check if there are other same-root transaction not finalized. // Check if there are other same-root transaction not finalized.
// TODO: it will increase read load, so we can only copy in two situations
// 1. if the tx is the first tx with this data root, copy to other tx_seqs if same_root_seq_list.first() == Some(&tx_seq) {
// 2. if it's in the middle of a tx sequence, copy only to the first tx_seq self.copy_tx_and_finalize(tx_seq, same_root_seq_list[1..].to_vec())?;
// although, some tx_seqs may not be finalized, it won't affect the data integrity. } else {
self.copy_tx_and_finalize(tx_seq, same_root_seq_list)?; // If this is not the first tx with this data root, copy and finalize the first one.
let maybe_first_seq = same_root_seq_list.first().cloned();
if let Some(first_seq) = maybe_first_seq {
if !self.check_tx_completed(first_seq)? {
self.copy_tx_and_finalize(tx_seq, vec![first_seq])?;
}
}
}
metrics::FINALIZE_TX_WITH_HASH.update_since(start_time); metrics::FINALIZE_TX_WITH_HASH.update_since(start_time);
Ok(true) Ok(true)